best practices: get rid of with pkgs;

modules/shell/exercism.nix

@@ -7,9 +7,11 @@
 {
   options.my.shell.exercism.enable = lib.mkEnableOption "enable";
   config = lib.mkIf config.my.shell.exercism.enable {
-    users.users.jawz.packages = with pkgs; [
-      exercism # learn to code
-      bats # testing system, required by Exercism
-    ];
+    users.users.jawz.packages = builtins.attrValues {
+      inherit (pkgs)
+        exercism # learn to code
+        bats # testing system, required by Exercism
+        ;
+    };
   };
 }

modules/shell/multimedia.nix

@@ -8,14 +8,16 @@
   options.my.shell.multimedia.enable = lib.mkEnableOption "enable";
   config = lib.mkIf config.my.shell.multimedia.enable {
     users.users.jawz.packages =
-      (with pkgs; [
-        gallery-dl # similar to yt-dlp but for most image gallery websites
-        yt-dlp # downloads videos from most video websites
-        ffmpeg # not ffmpreg, the coolest video conversion tool!
-        imagemagick # photoshop what??
-      ])
-      ++ [
-        (pkgs.python3Packages.buildPythonApplication (
+      let
+        packages = builtins.attrValues {
+          inherit (pkgs)
+            gallery-dl # similar to yt-dlp but for most image gallery websites
+            yt-dlp # downloads videos from most video websites
+            ffmpeg # not ffmpreg, the coolest video conversion tool!
+            imagemagick # photoshop what??
+            ;
+        };
+        ffpb = pkgs.python3Packages.buildPythonApplication (
           let
             pname = "ffpb";
             version = "0.4.1";
@@ -29,7 +31,11 @@
             buildInputs = [ pkgs.python3Packages.setuptools ];
             propagatedBuildInputs = [ pkgs.python3Packages.tqdm ];
           }
-        ))
+        );
+      in
+      packages
+      ++ [
+        ffpb
       ];
   };
 }

modules/shell/tools.nix

@@ -45,14 +45,16 @@
             pager = "less -FR";
             theme = "base16";
           };
-          extraPackages = with pkgs.bat-extras; [
-            batman # man pages
-            batpipe # piping
-            batgrep # ripgrep
-            batdiff # this is getting crazy!
-            batwatch # probably my next best friend
-            prettybat # trans your sourcecode!
-          ];
+          extraPackages = builtins.attrValues {
+            inherit (pkgs.bat-extras)
+              batman # man pages
+              batpipe # piping
+              batgrep # ripgrep
+              batdiff # this is getting crazy!
+              batwatch # probably my next best friend
+              prettybat # trans your sourcecode!
+              ;
+          };
         };
       };
     };
@@ -65,19 +67,21 @@
         vimAlias = true;
       };
     };
-    users.users.jawz.packages = with pkgs; [
-      ripgrep # modern grep
-      du-dust # rusty du similar to gdu
-      eza # like ls but with colors
-      fd # modern find, faster searches
-      fzf # fuzzy finder! super cool and useful
-      gdu # disk-space utility checker, somewhat useful
-      rmlint # amazing dupe finder that integrates well with BTRFS
-      tldr # man for retards
-      trash-cli # oop! did not meant to delete that
-      jq # linting
-      smartmontools # check hard drie health
-    ];
+    users.users.jawz.packages = builtins.attrValues {
+      inherit (pkgs)
+        ripgrep # modern grep
+        du-dust # rusty du similar to gdu
+        eza # like ls but with colors
+        fd # modern find, faster searches
+        fzf # fuzzy finder! super cool and useful
+        gdu # disk-space utility checker, somewhat useful
+        rmlint # amazing dupe finder that integrates well with BTRFS
+        tldr # man for retards
+        trash-cli # oop! did not meant to delete that
+        jq # linting
+        smartmontools # check hard drie health
+        ;
+    };
     environment.variables = {
       TEST = "AHHH";
       HISTFILE = "\${XDG_STATE_HOME}/bash/history";