From a9ef403ceaeb071f76ee1eba12b985180688fee5 Mon Sep 17 00:00:00 2001
From: Danilo Reyes <CaptainJawZ@protonmail.com>
Date: Sat, 9 Nov 2024 16:36:25 -0600
Subject: [PATCH] best practices: use builtins.path for local source

---
 pkgs/download/default.nix | 10 ++++++++--
 pkgs/vdhcoapp/default.nix |  5 ++++-
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/pkgs/download/default.nix b/pkgs/download/default.nix
index c81a3aa..47cfbaf 100644
--- a/pkgs/download/default.nix
+++ b/pkgs/download/default.nix
@@ -4,10 +4,16 @@
   ffmpeg,
   ...
 }:
-python3Packages.buildPythonApplication {
+let
   pname = "download";
   version = "2.5";
-  src = ../../scripts/download/.;
+in
+python3Packages.buildPythonApplication {
+  inherit pname version;
+  src = {
+    path = ../../scripts/download/.;
+    name = "${pname}-${version}";
+  };
   build-system = [ python3Packages.setuptools ];
   dependencies = builtins.attrValues {
     inherit (python3Packages)
diff --git a/pkgs/vdhcoapp/default.nix b/pkgs/vdhcoapp/default.nix
index 526d830..2a06dcb 100644
--- a/pkgs/vdhcoapp/default.nix
+++ b/pkgs/vdhcoapp/default.nix
@@ -41,7 +41,10 @@ buildNpmPackage (
 
     patches = [
       (substituteAll {
-        src = ./code.patch;
+        src = builtins.path {
+          path = ./code.patch;
+          name = "${src.name}-patch";
+        };
         inherit ffmpeg;
         filepicker = lib.getExe filepicker;
       })